-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
In Container view, render uncontained processes as distinct pseudonodes #127
Comments
"Not contained" is much less elegant 😛 |
Given the discussion re: pseudo nodes ("everything in a topology should be On Thu, May 28, 2015 at 10:30 AM, Peter Bourgon notifications@github.com
|
I don't understand the motivation. The proposal is to remove information from the UI, which undermines a lot of our user stories. Concretely: you want to see if a container is talking to more than just other containers. That single bit of information tells you a lot — it can identify misconfiguration, false assumptions you've made about your infrastructure, even identify backdoors or broken third-party software. At the moment I can't see how a topology with 1 less node is worth losing that value. Can you convince me? |
A large part of good UX is consistency; making everything in a single topology the same type make explaining what it is your showing to users easier (ideally to the extend where you don't need to explain). Exceptions (they are all containers, except that node represents incoming stuff from the internet, and that node represents stuff not in a container) make the UI less intuitive. I agree the use cases you've highlighted are important ones; perhaps there is an alternative? Perhaps uncontained workloads should be pseudo nodes (not all grouped into one, perhaps per-node), and perhaps we should revisit your suggestion of rendering pseudo nodes differently (smaller, greyed out...). |
I agree, but I think only a little bit less intuitive, and at a cost of a lot of loss of information. In this instance, I think the calculus doesn't work. That said, I'd be happy to explode the single Uncontained node into multiple per-host nodes. Shall we re-scope this ticket to that? And I think we should definitely render all pseudo-nodes differently. Filed #131. |
Are we OK closing this in favor of #131? |
I think there are a few things that need doing before we can close that
I'm kinda waiting in your big PR before I have a crack at this. On Wednesday, 3 June 2015, Peter Bourgon notifications@github.com wrote:
|
2bbc9a08 Merge pull request #140 from weaveworks/sched-http-retry c3726dea Add retries to sched util http calls 2cc7b5ac Merge pull request #139 from meghalidhoble/master fd9b0a72 Change : Modified the lint tools to skip the shfmt check if not installed. Why the change : For ppc64le the specific version of shfmt is not available, hence skipped completely the installation of shfmt tool. Thus this change made. bc645c70 Merge pull request #138 from dholbach/add-license-file a642e022 license: add Apache 2.0 license text 9bf59568 Merge pull request #109 from hallum/master d971d821 Merge pull request #134 from weaveworks/2018-07-03-gcloud-regepx 32e7aa2d Merge pull request #137 from weaveworks/gcp-fw-allow-kube-apiserver bbb6735e Allow CI to access k8s API server on GCP instances 764d46ca Merge pull request #135 from weaveworks/2018-07-04-docker-ansible-playbook ecc2a4e3 Merge pull request #136 from weaveworks/2018-07-05-gcp-private-ips 209b7fb6 tools: Add private_ips to the terraform output 369a655f tools: Add an ansible playbook that just installs docker a643e270 tools: Use --filter instead of --regexp with gcloud b8eca887 Merge pull request #128 from weaveworks/actually-say-whats-wrong 379ce2bb Merge pull request #133 from weaveworks/fix-decrypt 3b906b54 Fix incompatibility with recent versions of OpenSSL f091ab43 Merge pull request #132 from weaveworks/add-opencontainers-labels-to-dockerfiles 248def1b Inject git revision in Dockerfiles 64f2c280 Add org.opencontainers.image.* labels to Dockerfiles ea96d8ed add information about how to get help (#129) f066ccdd Make yapf diff failure look like an error 34d81d70 Merge pull request #127 from weaveworks/golang-1.10.0-stretch 89a0b4f8 Use golang:1.10.0-stretch image. ca69607f Merge pull request #126 from weaveworks/disable-apt-daily-test f5dc5d54 Create "setup-apt" role 7fab4413 Rename bazel to bazel-rules (#125) ccc83168 Revert "Gocyclo should return error code if issues detected" (#124) 1fe184f1 Bazel rules for building gogo protobufs (#123) b917bb89 Merge pull request #122 from weaveworks/fix-scope-gc c029ce01 Add regex to match scope VMs 0d4824b1 Merge pull request #121 from weaveworks/provisioning-readme-terraform 5a82d64c Move terraform instructions to tf section d285d78d Merge pull request #120 from weaveworks/gocyclo-return-value 76b94a47 Do not spawn subshell when reading cyclo output 93b3c0d5 Use golang:1.9.2-stretch image d40728f6 Gocyclo should return error code if issues detected c4ac1c3f Merge pull request #114 from weaveworks/tune-spell-check 89806560 Only check files 12ebc73a Don't spell-check pki files 578904ab Special-case spell-check the same way we do code checks e772ed59 Special-case on mime type and extension using just patterns ae82b50c Merge pull request #117 from weaveworks/test-verbose 89434738 Propagate verbose flag to 'go test'. 7c79b43c Merge pull request #113 from weaveworks/update-shfmt-instructions 258ef015 Merge pull request #115 from weaveworks/extra-linting e690202b Use tools in built image to lint itself 126eb561 Add shellcheck to bring linting in line with scope 63ad68f0 Don't run lint on files under .git 51d908a3 Update shfmt instructions e91cb0d3 Merge pull request #112 from weaveworks/add-python-lint-tools 0c87554d Add yapf and flake8 to golang build image 35679ee5 Merge pull request #110 from weaveworks/parallel-push-errors 3ae41b6f Remove unneeded if block 51ff31a5 Exit on first error 0faad9f7 Check for errors when pushing images in parallel d87cd026 Add arg flag override for destination socks host:port in pacfile. git-subtree-dir: tools git-subtree-split: 2bbc9a08a7f672eae62cfe110d7f536c6cc53ce3
No description provided.
The text was updated successfully, but these errors were encountered: