Don't make adjacency edges into 'the internet' if they refer to valid nodes #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ip := f(id) | ||
| return ip == nil || !netsContain(localNets, ip) | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
196-foo
branch
2 times, most recently
from
1448f4f to
c94f4a2
Compare
| @@ -201,9 +202,13 @@ func InternetOnlyPseudoNode(_ string, _ RenderableNode, dst string) (MappedNode, | |||
| // | |||
| // TODO change how pseudofuncs work, and eliminate this helper. | |||
| func trySplitAddr(addr string) (string, string) { | |||
| log.Println(addr) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Apart from that one extra Println, LGTM! |
…eparates scope and the rest of node id)
tomwilkie
added a commit
that referenced
this pull request
Jun 10, 2015
Don't make adjacency edges into 'the internet' if they refer to valid nodes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196