Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add middleware to detect jaeger trace context over HTTP #3325

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Add middleware to detect jaeger trace context over HTTP #3325

merged 2 commits into from
Aug 28, 2018

Conversation

leth
Copy link
Contributor

@leth leth commented Aug 23, 2018 •
edited
Loading

Previously scope would not honor http headers requesting that a request be traced.

Updates weaveworks/common to d442d08d89b51712ca61de3f7c14e2e218a739d7

@leth leth requested a review from bboreham August 23, 2018 12:04
dlespiau
dlespiau approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@dlespiau dlespiau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bboreham
Copy link
Collaborator

Why wouldn't this go in weaveworks/common/middleware ?

@leth
Copy link
Contributor Author

leth commented Aug 23, 2018

Why wouldn't this go in weaveworks/common/middleware ?

I didn't think this was possible initially; I've worked out how to do it now!

@leth leth mentioned this pull request Aug 23, 2018
Merged
Update weaveworks/common to d442d08d89b51712ca61de3f7c14e2e218a739d7
6f17a29 
Changes:
- Default diff-printer to hide details (#103) - da4c3ff
- Improve logging of http errors (#115) - f5a1710
- Update httpgrpc to match cortexproject/cortex#910 (#117) - 80ff076
- Expose the HTTP server from the server struct. (#118) - 1a7a6b3
- Add HTTP tracing middleware (#119) - d442d08
@leth leth force-pushed the trace-context-detect branch from c452f31 to e8eb7af Compare August 28, 2018 10:40
@leth leth force-pushed the trace-context-detect branch from e8eb7af to 67b887c Compare August 28, 2018 12:32
@bboreham bboreham merged commit 4e08ea0 into master Aug 28, 2018
@leth leth deleted the trace-context-detect branch August 28, 2018 13:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dlespiau dlespiau dlespiau approved these changes

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leth @bboreham @dlespiau