Update build tools #3797
Merged
Update build tools #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholbach
force-pushed
the
update-build-tools
branch
from
70fd52c to
93506f5
Compare
added 5 commits
September 3, 2020 10:15
604e133c2 Merge pull request #167 from weaveworks/update-scheduler-instructions bdd647e92 Merge pull request #169 from weaveworks/go-1.14.4 2c2792e7d Upgrade to Go 1.14.4 e6dd5e8f0 Merge pull request #168 from weaveworks/downgrade-werkzeug 144aa64c0 Restruct scheduler to use compatible version of werkzeug library cc807901d Update instructions on how to deploy gc/scheduler 51a217660 Merge pull request #166 from weaveworks/165-rename-circleci-to-wksctl bfd7a2bbe Renames circleci project wks -> wksctl afte code move a5f7be3cc Note that the API token was revoked 15e4cfb94 Merge pull request #164 from weaveworks/improve-lint dc8722589 Fix lint errors in Python code 8cb6a62a2 Set failure state if lint_files fails c635ce412 Simplify the no-arguments case 167b7ed57 Skip entire directories that match filter patterns 1caa455a6 Refactor: read filter patterns once at start 4cc7911e5 Merge pull request #163 from weaveworks/fix-lint 393808dab Merge pull request #162 from weaveworks/golang-python3 3c5fcd16e Make lint run on CircleCI f0936a1e9 lint all directories if not given a list 68f62a393 Fix typo in lint script 9ef44b057 Stop installing promtool 882df5ec5 Install python 3 instead of obsolete v2.7 988002377 Update Go to latest 1.13.3 2a2df5278 Merge pull request #161 from murali-reddy/terraform-update bf8ed23b9 update google_compute_instance arguments as per the latest documentation git-subtree-dir: tools git-subtree-split: 604e133c2b7eb805766eab7be28723ef1ccd32aa
dholbach
force-pushed
the
update-build-tools
branch
from
294ff4f to
1ab610c
Compare
Seems that go fmt has changed behaviour since these files were last checked in. Changes are all cosmetic.
All cosmetic.
The version we did have has a bug of not importing 'time'. Remove other vendor'd copy of SHOUT library which may or may not be used.
tools needs to be fixed in its own repo. We're not going to fix the generated output of protobuf.
Otherwise we get a compile error
bboreham
force-pushed
the
update-build-tools
branch
from
310b408 to
7243af7
Compare
|
One of the changes from the |
|
@dholbach can you either let me know what more needs to be done, or take off the 'draft' marker. |
dholbach
requested review from
bboreham,
fbarl,
qiell and
satyamz
as code owners
|
This looks good to me. Thanks for your work on this Bryan! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.