Only mount plugins directory if it exists #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets over problem with Docker for Mac where /var/run is read-only
The scope script is no longer creating it.
Paren in wrong place meant it was running the app and not getting any extra args
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets over a problem with Docker for Mac where
/var/runis read-only.Now, anyone wishing to use Scope plugins will have to ensure that directory (where the sockets used to communicate between Scope and plugins live) exists.
I'm not clear whether it is ever possible under Docker for Mac to create the
/var/run/scope/pluginsdirectory the code is looking for, or whether it will be necessary to parameterise the code.Also fix the Mac probe launch command - paren in wrong place meant it was running the app and not getting any extra args