Update build tools including Go 1.16.2 #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove complicated workaround in build.sh
The command and arguments for yarn runs was repeated many times.
'delegated' says the container side is in charge, and Docker doesn't have to work hard to keep the host in sync 'z' is needed for SELinux
This speeds up subsequent compilations
Otherwise it's blank on Apple M1 platform (at least) and builds fail Now we have to git-ignore .yarnrc file, which is created in the HOME dir.
All it does is set some environment variables so just set those on the command-line
Scope itself doesn't have any Python code. Disable Python test scheduler in CI - we set parallelism=1 so no point scheduling
bboreham
force-pushed
the
build-updates
branch
2 times, most recently
from
ff923d1 to
37d5157
Compare
Smaller that way, and more consistent (Note we run it with GC enabled; it crashes in CI otherwise)
gvt replaced by Go modules; github-release not used in CI
It calls 'go', which may not be present outside the build container
We only want to force CGO_ENABLED when cross-compiling for arm; it is on by default for native linux compilation and off by default for darwin cross-compilation.
Avoids warnings like "Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking"
It doesn't fail the test
2.1.3 is very old, and seems to be failing the build
dholbach
reviewed
Apr 6, 2021
|
Great work - this looks much cleaner now! Some cursory local testing went well as well! |
See docs at https://golang.org/ref/mod#go-mod-file-go The expected benefit from making this change is that the vendor directory will be used automatically, including tests.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node:10.19directly.