Update alpine base image to 3.13 #3838
Conversation
Update alpine 3.11 to latest patch version.
|
Happy to make a bigger jump. I don't believe Alpine flaws are exploitable in a normal Scope situation, but I recognize that folks run tools which highlight them. |
gaby
changed the title
|
@bboreham Great, changes have been made. Alpine now points to 3.13 |
|
Looks like the build fails now, you might try adding Also, the old Dockerfile was specific about |
|
Test still failing, I will take a look again tonight. The integration test for alpine 3.11.8 also failed, so it must be something else missing. |
Add bbc-tools as indicated on gobpf github.
|
The integration tests basically don't run at all for 3rd-party forks, due to mining. #2192 I have pushed your branch as 1st-party, so now the tests will re-run and hopefully succeed. I apoologise the error message is very hard to understand; it would be better to fail the job straight off if it doesn't have secrets. |
docker/Dockerfile.cloud-agent
Outdated
| WORKDIR /home/weave | ||
| RUN apk add --no-cache bash conntrack-tools iproute2 util-linux curl | ||
| RUN apk add --no-cache bash conntrack-tools iproute2 util-linux curl bcc-tools libpcap-dev |
There was a problem hiding this comment.
We don't want things relating to 'dev' in the final release container; we have a build container for those.
I backed out this change at 5331034
so we can check the CI run at https://app.circleci.com/pipelines/github/weaveworks/scope/357/workflows/a74f43bf-9696-4bff-bb60-a969f6a02b46
There was a problem hiding this comment.
@bboreham Thank you for looking at this, tests look good.
There was a problem hiding this comment.
Ok, do you want to update your branch so I can merge this PR, or shall I merge that branch above?
There was a problem hiding this comment.
@bboreham Done, I just removed the dev dependencies from my branch.
|
@bboreham, do you have any plans to official 1.13.2 release with the latest changes? Including new alpine? |
Update alpine 3.11 to latest patch version.
It would make more sense at this point to update to 3.13, let me know if you want make to make the change.
Change log for 3.11.8: https://alpinelinux.org/posts/Alpine-3.10.6-3.11.8-3.12.4-released.html