Update weaveworks/common #2301
Merged
Update weaveworks/common #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndstr
approved these changes
Sep 18, 2018
|
When rolled out in dev, this caused lots of errors in Cortex push. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix garbled error messages as seen at cortexproject/cortex#938
Full detail of what changed: weaveworks/common@0967b51...c3db87d
jaegertracing/jaeger-lib@4267858...ed3a127
Summary of weaveworks/common changes:
Update httpgrpc to match cortexproject/cortex#910 (weaveworks/common#117)
Raise default server timeouts from 5s to 30s (weaveworks/common#109)
Return errors when http/grpc servers exit. (weaveworks/common#92)
Expose jaeger metrics (weaveworks/common#114)
Default diff-printer to hide details (weaveworks/common#103)
Improve logging of http errors (weaveworks/common#115)
Add HTTP tracing middleware (weaveworks/common#119)
Print logrus output in logfmt format (weaveworks/common#121)
Don't trace http requests when using httpgrpc. (weaveworks/common#124)
Note Jaeger-lib changed their metric naming scheme jaegertracing/jaeger-lib#43