chore: fully enable the usetesting Go linter #4968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
usetesting-enable
branch
4 times, most recently
from
36b024f to
fc2680e
Compare
casibbald
approved these changes
May 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
This PR fully enables the
usetestinggolangci-linter. When upgrading to golangci-lint v2, I disabled some default checks to avoid too many changes during the upgrade.Why was this change made?
More linting improves our code quality and "forces" us to use newer Go features.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes