Event dispatch payloads for WebAuthn failure cases (#675)

Update failure event payloads to include additional context, such as `assertionResponse` or `optionsResponse`, improving error handling consistency. This ensures downstream handlers have access to more detailed information during WebAuthn failures.
web-auth · Jan 18, 2025 · f1432e7 · f1432e7
1 parent 281025e
commit f1432e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/stimulus/assets/dist/controller.js b/src/stimulus/assets/dist/controller.js
@@ -47,7 +47,7 @@ class default_1 extends Controller {
             }
         }
         catch (e) {
-            this._dispatchEvent('webauthn:assertion:failure', {exception: e});
+            this._dispatchEvent('webauthn:assertion:failure', { exception: e, assertionResponse: null });
             return;
         }
     }
@@ -70,7 +70,7 @@ class default_1 extends Controller {
             }
         }
         catch (e) {
-            this._dispatchEvent('webauthn:attestation:failure', {exception: e});
+            this._dispatchEvent('webauthn:attestation:failure', { exception: e, assertionResponse: null });
             return;
         }
     }
@@ -120,7 +120,7 @@ class default_1 extends Controller {
             body: JSON.stringify(data)
         });
         if (!optionsResponse.ok) {
-            this._dispatchEvent('webauthn:options:failure', {});
+            this._dispatchEvent('webauthn:options:failure', { exception: null, optionsResponse });
             return false;
         }
         const options = await optionsResponse.json();

diff --git a/src/stimulus/assets/src/controller.ts b/src/stimulus/assets/src/controller.ts
@@ -91,7 +91,7 @@ export default class extends Controller {
                 window.location.replace(this.requestSuccessRedirectUriValue);
             }
         } catch (e) {
-            this._dispatchEvent('webauthn:assertion:failure', {exception: e});
+            this._dispatchEvent('webauthn:assertion:failure', {exception: e, assertionResponse: null});
             return;
         }
     }
@@ -117,7 +117,7 @@ export default class extends Controller {
                 window.location.replace(this.creationSuccessRedirectUriValue);
             }
         } catch (e) {
-            this._dispatchEvent('webauthn:attestation:failure', {exception: e});
+            this._dispatchEvent('webauthn:attestation:failure', {exception: e, assertionResponse: null});
             return;
         }
     }
@@ -178,7 +178,7 @@ export default class extends Controller {
             body: JSON.stringify(data)
         });
         if (!optionsResponse.ok) {
-            this._dispatchEvent('webauthn:options:failure', {});
+            this._dispatchEvent('webauthn:options:failure', {exception: null, optionsResponse});
             return false;
         }