Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix php 8.4 deprecations #661

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix php 8.4 deprecations #661

merged 2 commits into from
Jan 3, 2025

Conversation

ptmkenny
Copy link
Contributor

@ptmkenny ptmkenny commented Dec 3, 2024

Target branch: 5.1.x
Resolves issue #

  • It is a Bug fix

PHP 8.4 warns that passing an implicit null is deprecated.

Fixed with Rector:

$rectorConfig->rule(\Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector::class);

@PhilETaylor PhilETaylor mentioned this pull request Dec 9, 2024
Merged
4 tasks
@Spomky Spomky merged commit 00e620f into web-auth:5.1.x Jan 3, 2025
10 of 15 checks passed
@Spomky
Copy link
Contributor

Spomky commented Jan 3, 2025

Many thanks!

@Spomky Spomky mentioned this pull request Feb 2, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptmkenny @Spomky