Add index on publicKeyCredentialId in Doctrine mapping

[Spomky]

This commit introduces a database index on the publicKeyCredentialId field in the PublicKeyCredentialSource mapping. The added index aims to optimize query performance for operations involving this column.

Target branch: 5.1.x
Resolves issue #665

• It is a Bug fix
• It is a New feature
• Breaks BC
• Includes Deprecations

[ruudk]

What about making it a unique column instead? That already gives it an index, plus it guarantees it's unique.

[nicodemuz]

I just deployed this to production via php bin/console doctrine:schema:update --force --dump-sql, and got the following error:

CREATE UNIQUE INDEX UNIQ_6AD0B4DF72A8BD77 ON public_key_credential_sources (public_key_credential_id);

 Updating database schema...


In ExceptionConverter.php line 118:
                                                                                                                                                                                             
  An exception occurred while executing a query: SQLSTATE[42000]: Syntax error or access violation: 1170 BLOB/TEXT column 'public_key_credential_id' used in key specification without a key length

I'm using MySQL.

[Spomky]

Hello @nicodemuz,

This should be fixed in 5.1.1

[nicodemuz]

Hello @nicodemuz,

This should be fixed in 5.1.1

@Spomky The MySQL query becomes now:

ALTER TABLE public_key_credential_sources CHANGE public_key_credential_id public_key_credential_id TINYTEXT NOT NULL;

With an error:

An exception occurred while executing a query: SQLSTATE[42000]: Syntax error or access violation: 1170 BLOB/TEXT column 'public_key_credential_id' used in key specification without a key length

I just tested that it (doctrine:schema:update) works with:

<field name="publicKeyCredentialId" type="string" unique="true" length="250"/>

But I'm not sure if this will break anything.