Fix coverity warnings

Signed-off-by: Raul Metsma <raul@metsma.ee>
web-eid · Feb 4, 2025 · f47fc15 · f47fc15
1 parent 054c7ef
commit f47fc15
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/libpcsc-cpp/include/pcsc-cpp/pcsc-cpp.hpp b/lib/libpcsc-cpp/include/pcsc-cpp/pcsc-cpp.hpp
@@ -131,7 +131,7 @@ struct ResponseApdu
 
     friend std::string operator+(std::string&& lhs, const ResponseApdu& rhs)
     {
-        return lhs + rhs.data + byte_vector {rhs.sw1, rhs.sw2};
+        return std::move(lhs) + rhs.data + byte_vector {rhs.sw1, rhs.sw2};
     }
 };
 

diff --git a/lib/libpcsc-cpp/src/utils.cpp b/lib/libpcsc-cpp/src/utils.cpp
@@ -74,7 +74,7 @@ std::ostream& operator<<(std::ostream& os, const pcsc_cpp::byte_vector& data)
     os << std::setfill('0') << std::hex;
     for (const auto byte : data)
         os << std::setw(2) << short(byte);
-    return os;
+    return os << std::setfill(' ') << std::dec;
 }
 
 std::string operator+(std::string lhs, const byte_vector& rhs)
-Original file line number
+Diff line change
@@ Expand Up / @@ -131,7 +131,7 @@ struct ResponseApdu @@
         friend std::string operator+(std::string&& lhs, const ResponseApdu& rhs)
         {
-            return lhs + rhs.data + byte_vector {rhs.sw1, rhs.sw2};
+            return std::move(lhs) + rhs.data + byte_vector {rhs.sw1, rhs.sw2};
         }
     };
@@ Expand Down @@