Skip to content

fix: should not stringify loader loading requests #7643

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: should not stringify loader loading requests #7643

merged 1 commit into from
Aug 21, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Aug 21, 2024 •
edited
Loading

Summary

Introduced in #7623

Should not JSON.stringify again as eval is removed.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Aug 21, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 21, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4206d07
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c5d01957514c00084b1c2d

@h-a-n-a h-a-n-a enabled auto-merge (squash) August 21, 2024 11:32
@h-a-n-a h-a-n-a merged commit ba230a4 into main Aug 21, 2024
34 checks passed
@h-a-n-a h-a-n-a deleted the fix-loader-import branch August 21, 2024 11:40
@SoonIter
Copy link
Member

TODO: add node20 esm-loader test :D

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Aug 21, 2024

Should enable test for Node 20: packages/rspack-test-tools/tests/configCases/loader/type-module/test.filter.js

@h-a-n-a h-a-n-a mentioned this pull request Aug 21, 2024
Open
@chenjiahan chenjiahan mentioned this pull request Aug 23, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @SoonIter