-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merge light-dark() into color-scheme? #1551
Comments
https://github.com/web-platform-dx/web-features/pull/1552/files shows what just merging the three features from #727 would look like. In terms of Baseline date, I guess that @bramus as the author of https://web.dev/articles/light-dark can you weigh in on how these groups of features is best split or merged in a way that makes sense to developers? |
I don't like the idea of merging features that shipped so far apart. Such data manipulation makes I think it would be more interesting to have separate bundles of features that are somehow related. A bundle of "things affecting and affected by On the other hand, we already can't use We still use data from BCD directly and still do our own Baseline calculations. I was hoping it would grow more accurate and complete over time so that eventually we could switch over. But it is fine if this never becomes possible. |
#727 added
color-scheme
,prefers-color-scheme
, andlight-dark()
as 3 separate features.In https://chromium-review.googlesource.com/c/chromium/src/+/5756571 @lilles gave the feedback that
light-dark()
depends oncolor-scheme
, and that it would have been shipped together if was in the spec at the time.The reason this isn't trivial is that it would remove two features, and we haven't done that yet since v1.0.0. Should we leave the features as some kind of tombstone entries with the meaning "I was merged into color-scheme, redirecting there would make sense"?
The text was updated successfully, but these errors were encountered: