Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add <hr> #1385

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Add <hr> #1385

merged 3 commits into from
Jul 16, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 11, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 11, 2024
ddbeck
ddbeck approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in on feature authoring! A couple of ideas to consider in comments here, but this would be OK to merge.

features/hr.yml Outdated Show resolved Hide resolved
features/hr.yml Show resolved Hide resolved
petele and others added 2 commits July 15, 2024 15:11
@petele @ddbeck
Update features/hr.yml
de2a836 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@petele
Merge branch 'main' into elem-hr
4c6b7b8
@petele
Copy link
Collaborator Author

petele commented Jul 15, 2024

Addressed feedback.

@captainbrosset captainbrosset merged commit 1fd72c6 into web-platform-dx:main Jul 16, 2024
3 checks passed
@petele petele deleted the elem-hr branch July 17, 2024 14:57
petele added a commit to petele/web-features that referenced this pull request Jul 18, 2024
@petele
Add <hr> (web-platform-dx#1385)
f503202
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petele @ddbeck @captainbrosset