Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add <picture> and <source> elements #1417

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Add <picture> and <source> elements #1417

merged 8 commits into from
Jul 25, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 16, 2024 •
edited
Loading

I couldn't find an element for <source> so I added it here. The description probably needs a little tweak.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
foolip
foolip reviewed Jul 18, 2024
View reviewed changes
features/picture.yml Outdated Show resolved Hide resolved
features/picture.yml Outdated Show resolved Hide resolved
@petele
Copy link
Collaborator Author

petele commented Jul 18, 2024

Creates a separate entry for <source>.

On <source> I used compute_from because the height and width properties only landed in late 2022. I'm open to putting them into their own feature, but not convinced that's required.

ddbeck
ddbeck reviewed Jul 19, 2024
View reviewed changes
features/source.yml Outdated Show resolved Hide resolved
@petele @ddbeck
Update features/source.yml
b5b4797 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@petele petele requested a review from ddbeck July 19, 2024 13:55
@petele petele requested review from ddbeck and foolip July 23, 2024 14:09
@petele petele enabled auto-merge July 25, 2024 14:58
@petele petele merged commit 85745ed into web-platform-dx:main Jul 25, 2024
3 checks passed
@petele petele deleted the elem-picture branch July 25, 2024 14:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ddbeck ddbeck Awaiting requested review from ddbeck

@foolip foolip Awaiting requested review from foolip

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petele @ddbeck @foolip