Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add <iframe> element #1426

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Add <iframe> element #1426

merged 8 commits into from
Jul 19, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 16, 2024

Used compute_from: html.elements.iframe since a number of the sandbox attributes are later in life

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
@foolip
Copy link
Collaborator

foolip commented Jul 18, 2024

Caniuse has https://caniuse.com/iframe-srcdoc and https://caniuse.com/iframe-sandbox as separate features. These are quite old by now, but I wonder if we still shouldn't just create separate features for these for now? @ddbeck WDYT?

@foolip
Copy link
Collaborator

foolip commented Jul 19, 2024

I've sent PRs for separate features for sandbox and srcdoc:
#1468
#1469

@petele can you exclude those keys from this feature?

@petele
Copy link
Collaborator Author

petele commented Jul 19, 2024

Removed sandbox and srcdoc, which means compute_from was no longer necessary, so removed that too.

@foolip
Copy link
Collaborator

foolip commented Jul 19, 2024

@petele can you add back compute_from? Without it, the feature is much newer than it should be.

@foolip foolip enabled auto-merge (squash) July 19, 2024 14:29
@foolip foolip merged commit 49da860 into web-platform-dx:main Jul 19, 2024
3 checks passed
@petele petele deleted the elem-iframe branch July 25, 2024 17:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants