Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add <object> element #1438

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Add <object> element #1438

merged 7 commits into from
Jul 22, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 16, 2024

Prob needs a little extra review

  • Used compute_from: html.elements.object due to newer attributes
  • obsolete?

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with #1437 I'm not sure how <object> is used today, if we can give an example.

features/object.yml Outdated Show resolved Hide resolved
@petele
Copy link
Collaborator Author

petele commented Jul 17, 2024

There don't seem to be many legit use cases, the only one I've heard so far is embedding an SVG file will execute any embedded scripts, where as using the <img> tag will not run the scripts.

Based on that, I think I'd lean towards keeping the generic description, its rarely used, hasn't been deprecated, but is still Baseline.

@petele petele requested a review from foolip July 17, 2024 18:53
spec:
- https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-object-element
- https://html.spec.whatwg.org/multipage/obsolete.html#param
description: The `<object>` element represents an external resource such as an external plugin or nested browsing context.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"browsing context" is spec language that I wouldn't expect most web developers to be able to parse. Avoiding that and elaborating on the real reason this element exists:

Suggested change
description: The `<object>` element represents an external resource such as an external plugin or nested browsing context.
description: The `<object>` element embeds an external resource such as a PDF or SVG document. It was historically used for plugins such as Shockwave Flash.

@ddbeck can you review so we don't have more rounds of description review after this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider that the description should work for <embed>. The word "embeds" would make it a bit circular, but I can't come up with anything better. Back to "represents"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building on @foolip's description, I'd make one minor tweak to avoid the word embed.

The <object> element inserts an external resource such as a PDF or SVG file into the document. It was historically used for plugins such as Shockwave Flash.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @foolip's original, though <embed> will need to say "represents." It's not perfectly consistent, but produces a good outcome: you search for "embed" and you'll get both features.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

produces a good outcome: you search for "embed" and you'll get both features

I'm unsure why would that be a good outcome? My expectation of searching for "embed" would only return the <embed> element.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because they're closely related and easily confused (at least they are for me)—if I searched for one I'd appreciate being reminded of the other. But I don't have my heart set on this either; "represents" is fine too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've updated the description to keep represents and use the rest of @foolip's description.

@foolip foolip requested a review from ddbeck July 18, 2024 15:30
@foolip foolip merged commit 9282ea7 into web-platform-dx:main Jul 22, 2024
3 checks passed
@petele petele deleted the elem-object branch July 23, 2024 14:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants