Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add <output> element #1442

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Add <output> element #1442

merged 7 commits into from
Jul 24, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 16, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
@petele
Copy link
Collaborator Author

petele commented Jul 23, 2024

@ddbeck & @foolip - I've merged to main, but I'm still getting a weird value in the output.yml.dist file for the baseline dates. I'm not sure what's going on here. Can you take a peek?

@foolip
Copy link
Collaborator

foolip commented Jul 23, 2024

@petele if you're not getting the same results locally as the CI, it's probably because compute-baseline JS files haven't been updated. Running npm install inside packages/compute-baseline should fix it. @ddbeck can we avoid this someone?

As for the range symbol, the problem is that BCS data about Edge is uncertain and affects the date. We'll need to test this in Edge and update BCD to be sure an out the correct dates.

@petele
Copy link
Collaborator Author

petele commented Jul 23, 2024

@petele if you're not getting the same results locally as the CI, it's probably because compute-baseline JS files haven't been updated. Running npm install inside packages/compute-baseline should fix it. @ddbeck can we avoid this someone?

I'm getting the same error locally as well, so its not just in the CI

@foolip
Copy link
Collaborator

foolip commented Jul 23, 2024

Oh... it could be that this is the first feature with a range on the date, and that fails in a weird way. We should either disallow it and fail with a clear message, or just handle it.

ddbeck added a commit to ddbeck/web-features that referenced this pull request Jul 24, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #1496 to deal with the error here. I've also got a suggestion for the description.

features/output.yml Outdated Show resolved Hide resolved
foolip pushed a commit that referenced this pull request Jul 24, 2024
petele and others added 2 commits July 24, 2024 09:45
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@petele petele requested a review from ddbeck July 24, 2024 13:49
@ddbeck ddbeck merged commit d70b8d7 into web-platform-dx:main Jul 24, 2024
3 checks passed
@petele petele deleted the elem-output branch July 25, 2024 17:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants