Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release web-features 1.0.0 #1451

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Jul 17, 2024

Hoorah.

Closes #735.

@foolip foolip requested a review from ddbeck July 17, 2024 16:16
@foolip
Copy link
Collaborator Author

foolip commented Jul 18, 2024

#1398 should also be merged before 1.0.0, of course.

@captainbrosset
Copy link
Contributor

Definitely not against going to 1.0.0 if that helps us communicate breaking changes more easily.
Unlike more traditional libraries, though, which you can still keep on using for a while if you don't have time to update your code to adapt to the breaking change, you can't really keep using web-features 1.0.0 if 2.0.0 is out. Otherwise you risk displaying outdated browser version and baseline information.
I'm not saying we shouldn't do it. Let's do all, by all means, but maybe have something in the README that tells consumers how each version comes with updated dates/versions/baseline statuses, and that it's a best practice (or really, the only practice) to keep updating their dependency.

@captainbrosset
Copy link
Contributor

What about #1450? It's a schema change. Should we wait for that to land before going to 1.0.0?

@foolip
Copy link
Collaborator Author

foolip commented Jul 18, 2024

@captainbrosset, yes, that too! I sent it now because it's a breaking change, sorry I didn't link them together.

@ddbeck
Copy link
Collaborator

ddbeck commented Jul 18, 2024

Let's do all, by all means, but maybe have something in the README that tells consumers how each version comes with updated dates/versions/baseline statuses, and that it's a best practice (or really, the only practice) to keep updating their dependency.

Yes, let's do this. Also, we can mark the previous releases on npm as deprecated. It might even be a good idea to do that on a rolling basis (e.g., if you're using a version of web-features more than a month old, you start getting the deprecation warning from npm).

@foolip
Copy link
Collaborator Author

foolip commented Jul 19, 2024

#1398 and #1450 have been merged now.

One more thing we can do while we're add it is include the schema in the release. I'll do that now.

@foolip
Copy link
Collaborator Author

foolip commented Jul 19, 2024

#1348 is also done now.

@foolip foolip merged commit c0797be into web-platform-dx:main Jul 19, 2024
3 checks passed
@foolip foolip deleted the release-1.0.0 branch July 19, 2024 16:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements for 1.0
3 participants