Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Retitle "input event" feature to "input (event)" #1492

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Jul 23, 2024

This is a special case. We use only the name of a lone event elsewhere (e.g., "scrollend"), but this event shares a name with the element ("<input>"). This moves the disambiguation text to parentheses to distinguish the name of the thing ("input").

Extracted from #1026.

This is a special case. We use only the name of a lone event elsewhere (e.g., "scrollend"), but this event shares a name with the element ("<input>"). This moves the disambiguation text to parentheses to distinguish the name of the thing ("input").
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 23, 2024
@foolip
Copy link
Collaborator

foolip commented Jul 23, 2024

To avoid setting a precedent too broad, for me a key reason is to avoid conflation with input events, referring to the whole class of events that fire on user input.

I'd like to see more cases before turning the distinction between name and disambiguation, and the use of parenthesis, into a firm guideline.

@foolip foolip merged commit b3b898d into web-platform-dx:main Jul 23, 2024
3 checks passed
@ddbeck ddbeck deleted the input-event-rename branch July 25, 2024 09:05
@ddbeck ddbeck mentioned this pull request Sep 10, 2024
@ddbeck ddbeck mentioned this pull request Nov 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants