Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Give the draft updater workflow pull requests write permission" #1568

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Aug 9, 2024

Reverts #1517

@foolip
Copy link
Collaborator Author

foolip commented Aug 9, 2024

I tested in https://github.com/foolip/web-features/actions/runs/10315510828/job/28555822160 that this fixes the problem. I guess that be specifying permissions, only the set permissions are there, and if it's omitted the default permissions apply. I think that permissions to write to the repo was the missing bit, but don't see why we should tinker with permissions at all. It was just a failed attempt to fix the problem.

@foolip foolip requested a review from ddbeck August 9, 2024 08:06
@foolip foolip mentioned this pull request Aug 9, 2024
@foolip foolip requested a review from tropicadri August 9, 2024 08:13
@ddbeck ddbeck merged commit 09e182f into main Aug 9, 2024
3 checks passed
@ddbeck ddbeck deleted the revert-1517-github-actions-permissions branch August 9, 2024 08:53
@foolip
Copy link
Collaborator Author

foolip commented Aug 9, 2024

It's alive! #1570

Thank you @tropicadri!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants