Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add caret-color #1597

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add caret-color #1597

merged 3 commits into from
Aug 15, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Aug 14, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 14, 2024
ddbeck
ddbeck approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. One style nit (CSS property features are often named directly after the property, when it's not ambiguous), but this is ready to merge as soon as the suggestion is applied.

features/caret-color.yml Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from ddbeck August 15, 2024 12:27
@ddbeck ddbeck merged commit 321a53a into web-platform-dx:main Aug 15, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnw @ddbeck