Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Async generators #1665

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Add Async generators #1665

merged 3 commits into from
Sep 16, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Aug 26, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 26, 2024
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review. Only non-blocking suggestions.

@@ -0,0 +1,17 @@
name: Async generators
description: Async generator functions (`async function*`) are asynchronous and always yield `Promise` objects.
group: javascript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a generators group?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add that as a follow up when this PR and #1664 have been merged

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both merged now. 👍

features/async-generators.yml Outdated Show resolved Hide resolved
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@ddbeck ddbeck merged commit f6b16a5 into web-platform-dx:main Sep 16, 2024
3 checks passed
@Elchi3 Elchi3 deleted the async-generators branch September 16, 2024 17:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants