Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fill in more of AbortSignal #1697

Merged
merged 9 commits into from
Sep 3, 2024
Merged

Conversation

autonome
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 28, 2024
@jamesnw
Copy link
Collaborator

jamesnw commented Aug 28, 2024

Is it intentional that you're removing the AbortController items? The api.AbortSignal.abort_event and api.AbortSignal.aborted items also were removed.

If you define compat_features in AbortSignal.yml, it will not combine it with the existing tagged BCD keys, so you need to add those as well.

@autonome autonome marked this pull request as draft August 28, 2024 15:25
@autonome
Copy link
Collaborator Author

Is it intentional that you're removing the AbortController items? The api.AbortSignal.abort_event and api.AbortSignal.aborted items also were removed.

If you define compat_features in AbortSignal.yml, it will not combine it with the existing tagged BCD keys, so you need to add those as well.

Meant to mark as draft, was just pushing as a placeholder. Definitely not planning to wipe out the existing keys!

@autonome autonome marked this pull request as ready for review August 29, 2024 08:15
features/aborting.yml Outdated Show resolved Hide resolved
features/aborting.yml Show resolved Hide resolved
@autonome autonome requested a review from ddbeck September 3, 2024 15:35
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ddbeck ddbeck merged commit fddba77 into web-platform-dx:main Sep 3, 2024
3 checks passed
@autonome autonome deleted the more-abort-signal branch September 4, 2024 11:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants