Add gradients feature #1832
Merged
Add gradients feature #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
|
Splitting |
ddbeck
approved these changes
Oct 9, 2024
features/gradients.yml
Outdated
| @@ -0,0 +1,31 @@ | |||
| name: Gradients | |||
| description: The `linear-gradient()`, `radial-gradient()` CSS functions and their repeating counterparts create background that progress smoothly between multiple colors. | |||
There was a problem hiding this comment.
nits
Suggested change
| description: The `linear-gradient()`, `radial-gradient()` CSS functions and their repeating counterparts create background that progress smoothly between multiple colors. | |
| description: The `linear-gradient()` and `radial-gradient()` CSS functions and their repeating counterparts create backgrounds that progress smoothly between multiple colors. |
features/gradients.yml
Outdated
| name: Gradients | ||
| description: The `linear-gradient()`, `radial-gradient()` CSS functions and their repeating counterparts create background that progress smoothly between multiple colors. | ||
| spec: https://drafts.csswg.org/css-images-3/#gradients | ||
| # Todo: caniuse support needs to be reconciled for Safari and Firefox. |
There was a problem hiding this comment.
Suggested change
| # Todo: caniuse support needs to be reconciled for Safari and Firefox. | |
| # TODO: caniuse support needs to be reconciled for Safari and Firefox. |
|
Oh, on the question of splitting: I'm agnostic. If you want to split it, I'll re-review. But I suspect we'll want a way to address both and a |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was on the fence about combining linear and radial gradients, but this mirrors Can I Use and MDN, and there isn't a separate support story.