Add features for Cookie Store API #1858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
requested changes
Sep 27, 2024
Comment on lines
+5
to
+12
| - api.CookieChangeEvent.changed.partitioned_property | ||
| - api.CookieChangeEvent.deleted.partitioned_property | ||
| - api.CookieStore.delete.partitioned_option | ||
| - api.CookieStore.get.partitioned_return_property | ||
| - api.CookieStore.getAll.partitioned_return_property | ||
| - api.CookieStore.set.partitioned_option | ||
| - api.ExtendableCookieChangeEvent.changed.partitioned_property | ||
| - api.ExtendableCookieChangeEvent.deleted.partitioned_property |
There was a problem hiding this comment.
This looks incomplete. CHIPS is a bigger feature than the cookie store API. This is missing at least an HTTP header, but I don't know enough about it to say what else might be missing.
| name: Cookie Store API | ||
| description: TODO | ||
| name: Cookie store | ||
| description: To write... |
There was a problem hiding this comment.
Do you want to take a crack at writing these descriptions? Or am I jumping the gun with a review and this was supposed to be a draft PR?
There was a problem hiding this comment.
I'm not good at writing descriptions, so I kind of left this as a request for assistance writing one!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two features related to cookie storage: Cookie Store and Partitioned Cookies.