Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add WebDriver extension features #1956

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Oct 14, 2024

Maps the remaining webdriver.* keys for sensor and compute pressure WebDriver endpoints.

I know @ddbeck had some push back against this in #1592 (comment) but I think WebDriver extensions deserve their own features and they should belong in two groups: webdriver and a group for the APIs themselves.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 14, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can see when I'm in the minority on an issue. Some incremental suggestions in line comments.

features/webdriver-compute-pressure.yml Outdated Show resolved Hide resolved
features/webdriver-compute-pressure.yml Outdated Show resolved Hide resolved
features/webdriver-sensors.yml Outdated Show resolved Hide resolved
groups/compute-pressure.yml Outdated Show resolved Hide resolved
Elchi3 and others added 2 commits October 14, 2024 15:21
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@ddbeck ddbeck merged commit 7ee7dc9 into web-platform-dx:main Oct 14, 2024
3 checks passed
@Elchi3 Elchi3 deleted the webdriver-extensions branch October 14, 2024 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants