Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add group as an omittable field #649

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Feb 26, 2024

Illustration for #648

@Elchi3 Elchi3 mentioned this pull request Feb 26, 2024
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to treats groups like specs and make it a string or list or strings depending on how many there are. I think a single group is going to be common, probably more common than multiple groups. So I'd call it group in singular just like spec.

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Mar 1, 2024

Updated to be consistent with the spec field. Like for spec, when there is just one entry, I've removed the yaml list. So, If this sees adaption in the schema, we will need something like this:

"group": {
  "anyOf": [
    {
      "description": "Group identifier",
      "type": "string"
    },
    {
      "items": {
        "description": "Group identifier",
        "type": "string"
      },
      "minItems": 2,
      "type": "array"
    }
  ],
  "description": "Group"
}, 

@Elchi3 Elchi3 changed the title Add groups as an omittable field Add group as an omittable field Mar 1, 2024
@foolip
Copy link
Collaborator

foolip commented Mar 1, 2024

Since it's not published and doesn't get in the way, I'd be happy to merge this. We're still discussing how to represent group properties (name/description/etc.) and group hierarchy in #648, but we can do that in a separate PR.

@foolip
Copy link
Collaborator

foolip commented Mar 8, 2024

@Elchi3 I haven't merged this because it's draft, but I see your 👍 and will undraft it myself for merging :)

@foolip foolip marked this pull request as ready for review March 8, 2024 15:31
@foolip foolip merged commit 0435f36 into web-platform-dx:main Mar 8, 2024
2 checks passed
@Elchi3 Elchi3 deleted the groups branch March 8, 2024 15:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants