Skip to content

Commit

Permalink
Temporary workaround for Linter err (#3837)
Browse files Browse the repository at this point in the history
* Temporary workaround for linter err

golangci/golangci-lint#4733

* Update Makefile

* Update Makefile

* Update backfill.go
  • Loading branch information
KyleJu authored May 21, 2024
1 parent 56f4453 commit 70824f6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,6 @@ linters-settings:
# See: https://github.com/web-platform-tests/wpt.fyi/blob/main/go.mod
replace-allow-list:
- launchpad.net/gocheck
errcheck:
# TODO: Remove following line when version 1.58.3 is released.
ignore: ""
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ go_lint: golint go_test_tag_lint

# TODO: run on /shared/, /util/, /webapp/, /webdriver/
golangci_lint: golangci-lint
golangci-lint cache clean
golangci-lint run ./api/...

go_test_tag_lint:
Expand Down
2 changes: 1 addition & 1 deletion api/query/cache/backfill/backfill.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (m *backfillMonitor) Stop() error {
return m.ProxyMonitor.Stop()
}

// nolint:ireturn // TODO: Fix ireturn lint error
// nolint:all // TODO: Fix ireturn lint error
func (*backfillIndex) Bind([]shared.TestRun, query.ConcreteQuery) (query.Plan, error) {
return nil, nil
}
Expand Down

0 comments on commit 70824f6

Please # to comment.