-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create resource timing entries for fetch network errors #30970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! A few comments
ebf1400
to
13f67ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
13f67ce
to
c2496a3
Compare
Modified test to include only 5 scenarios for now:
Currently Chrome & Firefox are inconsistent around which of these create a resource timing entry. |
This actually catches a Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1523275 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nit and suggestion for another test
The Firefox failures are legit, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1523275. How does this get merged when it fails firefox nightly? |
Added a test for mixed content. |
An initial tests for whatwg/fetch#1215
Added test cases for several network error scenarios. The test cases verify that a resource timing entry is created for those resources, without the "internal" timing info (redirects, networking), as if the resource was cross-origin no-cors and lacked TAO.
The error test cases include:
These tests come in conjunction with whatwg/fetch#1311