Revise filtering for Content-Encoding in ResourceTiming #50456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value from the http header can be of multiple codings, or not properly formatted. Per discussion on w3c/resource-timing#381, multiple codings should be transformed to "multiple"; "identity" is not allowed in response header; and the coding value should be formatted if it's not in http header. Bug: 327941462 Change-Id: I9048423c5ad562d8001562324cb35f72ef8ac5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6215331 Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Commit-Queue: Guohui Deng <guohuideng@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1415037}
wpt-pr-bot
approved these changes
Feb 3, 2025
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6215331
branch
from
9066882 to
f554add
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value from the http header can be of multiple codings, or not
properly formatted.
Per discussion on w3c/resource-timing#381,
multiple codings should be transformed to "multiple"; "identity" is
not allowed in response header; and the coding value should be
formatted if it's not in http header.
Bug: 327941462
Change-Id: I9048423c5ad562d8001562324cb35f72ef8ac5da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6215331
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1415037}