Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Problem with translation no glossary given #235

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix Problem with translation no glossary given #235

merged 2 commits into from
May 15, 2023

Conversation

calien666
Copy link
Member

@calien666 calien666 commented May 15, 2023

If no glossary is given, the TranslateHook crashes because of wrong return param. This fix corrects the return value to an empty array.

Additionally, the label for translation dropdown is removed due to backend UI limitations.

@calien666 calien666 requested a review from sbuerk May 15, 2023 13:51
Copy link
Contributor

@sbuerk sbuerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checked, but should we do the same guard on main (4.x) ? (up-port)
At least for the meanwhile, and recheck it on 4.x during code streamlineing and hardening ?

@calien666 calien666 merged commit df8fb0d into 3.0 May 15, 2023
@calien666 calien666 deleted the bugfix/232 branch May 15, 2023 14:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants