Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Bump underscore #4051

Merged
merged 3 commits into from
May 8, 2021
Merged

Bump underscore #4051

merged 3 commits into from
May 8, 2021

Conversation

GregTheGreek
Copy link
Contributor

@GregTheGreek GregTheGreek commented May 8, 2021

This closes #4049 by bumping underscore

This also closes the following pull requests opened by dependabot:
closes #4038,closes #4039,closes #4040,closes #4041,closes #4042,closes #4043,closes #4047,closes #4048

@GregTheGreek GregTheGreek requested a review from spacesailor24 May 8, 2021 19:54
@render
Copy link

render bot commented May 8, 2021

@coveralls
Copy link

Pull Request Test Coverage Report for Build 823802577

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 226 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.5%) to 76.21%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 82.27%
packages/web3-utils/src/utils.js 27 10.74%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.92%
packages/web3-utils/src/index.js 42 32.12%
packages/web3-eth-accounts/src/index.js 85 33.06%
Totals Coverage Status
Change from base Build 720288779: 2.5%
Covered Lines: 3155
Relevant Lines: 3927

💛 - Coveralls

@GregTheGreek GregTheGreek merged commit fdbda49 into 1.x May 8, 2021
@GregTheGreek GregTheGreek deleted the security/update-underscore branch May 8, 2021 21:12
@spacesailor24 spacesailor24 mentioned this pull request May 9, 2021
spacesailor24 added a commit that referenced this pull request Jul 2, 2021
* Release/1.3.5 (#3974)

* Update changelog

* Built dist

* Update version numbers

* v1.3.5

Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal>

* Bump underscore (#4051)

* bump underscore

* update package-locks

* bump lcoks again

* Release 1.3.6 (#4053)

* Update CHANGELOG and ran npm i

* Built lib for 1.3.6-rc.0

* v1.3.6-rc.0

* npm i

* Built lib for 1.3.6-rc.1

* v1.3.6-rc.1

* 1.3.6-rc.2 (#4059)

* npm i && npm audit fix

* Manually bump version to 1.3.6-rc.2

* Built lib for 1.3.6-rc.2

* v1.3.6-rc.2

* 1.3.6-rc.2 fixes (#4062)

* Manually update dependency versions to 1.3.6-rc.2

* Accidental commit

* npm i

* Manually update web3 dependency version to 1.3.6-rc.2

* npm i

* Built manually for 1.3.6-rc.2

* Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Add web3-core-helpers as dev dependency

* Add web3-core-helpers as dev dependency

* Fixing 1.3.6-rc.2 related issues (#4063)

* Remove web3-eth-ens as dependency

* Regen package-locks and build lib

* Remove dtslint from ci scripts (#4064)

* Remove web3-eth-ens as dependency

* Regen package-locks and build lib

* Remove npm run dtslint from build and lint

* 1.3.6-rc.2 Fixes (#4065)

* Remove web3-eth-ens as dependency

* Regen package-locks and build lib

* Remove npm run dtslint from build and lint

* Add back removed package: web3-eth-ens

* npm i

* Build lib

* Add back npm run dtslint

* Update geth-dev-assistant

* v1.3.6

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Add unsubscribeByID (#4061)

* adding function unsubscribe by id

* adding an unsubscribe testcase

* adding testcase

* seperated unsubscribebyid to its own method

* adding testcases

* adding await

* fixing testcases

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>

* ignore .md and docs (#4077)

* adding berlin tx support (#4109)

* add berlin tx support

* update install locations

* update package name in comment

* fix existing tests to support new tx sigining format

* remove build

* remove old test case

* use latest ethereumjs/tx

* bump deps and fix test

* update hashes

* fix messageHash, decoding bug

* fix tests

* add hack

* adding eip2930 and common object

* fix lint updating package-lock

* fix berlin tx signing and recovery

* updating ethereumjs/tx package

* updating checksum

* removing helper.js

* updating changelog and docs

* fixing typo

Co-authored-by: Gregory Markou <gregorymarkou@gmail.com>

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth (#4154)

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Fix typo

* Release v1.4.0 (#4118)

* npm run build for 1.4.0-rc.0

* v1.4.0-rc.0

* 1.4.0 Geth version downgrade (#4149)

* Update pull Geth docker version from stable to pre-london (1.10.3)

* Update CHANGELOG

* v1.4.0

Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal>
Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>
Co-authored-by: Gregory Markou <gregorymarkou@gmail.com>
@spacesailor24 spacesailor24 mentioned this pull request Jul 2, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2021-23358 - Arbitrary Code Execution (Underscore)
3 participants