Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add block tag support for eth_feeHistory #4224

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Add block tag support for eth_feeHistory #4224

merged 5 commits into from
Aug 5, 2021

Conversation

spacesailor24
Copy link
Contributor

No description provided.

brg8 and others added 2 commits August 4, 2021 21:53
@brg8 @spacesailor24
Accept predefined block numbers for eth_feeHistory (#4213)
9dde5a7 
* Accept predefined block numbers for eth_feeHistory

* Update feeHistory tests to reflect new input formatter

Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
@spacesailor24
Add block tag tests
b1b977c
@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Aug 5, 2021
@render
Copy link

render bot commented Aug 5, 2021

Your Render PR Server URL is https://web3-js-pr-4224.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c45l91sobjd906i8mae0.

@coveralls
Copy link

coveralls commented Aug 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1100077324

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 254 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 75.007%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 6 84.39%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/utils.js 31 8.46%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-eth-accounts/src/index.js 110 26.12%
Totals Coverage Status
Change from base Build 1100070664: 2.4%
Covered Lines: 3202
Relevant Lines: 4033
💛 - Coveralls

@spacesailor24 spacesailor24 merged commit 29febb8 into 1.x Aug 5, 2021
@spacesailor24 spacesailor24 deleted the wyatt/eth_feeHistory-blocktags branch August 5, 2021 03:56
@spacesailor24 spacesailor24 mentioned this pull request Aug 5, 2021
Merged
This was referenced Nov 24, 2021
Open
Open
Open
Open
Open
@affiliatedkat affiliatedkat mentioned this pull request Feb 2, 2024
Open
@Manny27nyc Manny27nyc mentioned this pull request Feb 2, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Feb 2, 2024
Open
This was referenced Feb 3, 2024
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@luu-alex luu-alex luu-alex approved these changes

Assignees

@GregTheGreek GregTheGreek

@luu-alex luu-alex

@jdevcs jdevcs

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spacesailor24 @coveralls @luu-alex @GregTheGreek @jdevcs @brg8