Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

signTransaction fix #4295

Merged
merged 5 commits into from
Sep 10, 2021
Merged

signTransaction fix #4295

merged 5 commits into from
Sep 10, 2021

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Sep 7, 2021

Description

Fixes #4292

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Sep 7, 2021

@coveralls
Copy link

coveralls commented Sep 7, 2021

Pull Request Test Coverage Report for Build 1222374796

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.915%

Totals Coverage Status
Change from base Build 1218866309: 0.0%
Covered Lines: 3324
Relevant Lines: 4310

💛 - Coveralls

@jdevcs jdevcs linked an issue Sep 8, 2021 that may be closed by this pull request
@jdevcs jdevcs marked this pull request as ready for review September 8, 2021 11:50
nazarhussain
nazarhussain previously approved these changes Sep 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.eth.accounts.signTransaction returning invalid
5 participants