Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add getMaxPriorityFeePerGas method #6748

Merged

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #4195

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c1acca7
Status: ✅  Deploy successful!
Preview URL: https://e2e4060f.web3-js-docs.pages.dev
Branch Preview URL: https://4195-plans-to-support-eth-ma.web3-js-docs.pages.dev

View logs

Copy link

github-actions bot commented Jan 24, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 0 619 KB 619 KB -
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
web3.min.js 0 601 KB 601 KB -
../lib/commonjs/index.d.ts 0 8.63 KB 8.63 KB -
../lib/commonjs/accounts.d.ts 0 3.89 KB 3.89 KB -
../lib/commonjs/types.d.ts 0 2.45 KB 2.45 KB -
../lib/commonjs/web3.d.ts 0 1.14 KB 1.14 KB -
../lib/commonjs/abi.d.ts 0 999 bytes 999 bytes -
../lib/commonjs/eth.exports.d.ts 0 280 bytes 280 bytes -
../lib/commonjs/providers.exports.d.ts 0 148 bytes 148 bytes -
../lib/commonjs/version.d.ts 0 60 bytes 60 bytes -

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

github-actions bot commented Jan 24, 2024

Benchmark

Benchmark suite Current: fc92fc8 Previous: 6c075db Ratio
processingTx 9378 ops/sec (±4.46%) 9301 ops/sec (±4.81%) 0.99
processingContractDeploy 38567 ops/sec (±8.45%) 39129 ops/sec (±7.62%) 1.01
processingContractMethodSend 20288 ops/sec (±6.28%) 19443 ops/sec (±5.19%) 0.96
processingContractMethodCall 39758 ops/sec (±5.72%) 38971 ops/sec (±6.34%) 0.98
abiEncode 46472 ops/sec (±7.38%) 44252 ops/sec (±6.92%) 0.95
abiDecode 31731 ops/sec (±8.25%) 30419 ops/sec (±8.89%) 0.96
sign 1630 ops/sec (±3.29%) 1656 ops/sec (±4.08%) 1.02
verify 384 ops/sec (±0.57%) 373 ops/sec (±0.78%) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #6748 (fc92fc8) into 4.x (9023511) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6748      +/-   ##
==========================================
- Coverage   92.03%   92.02%   -0.01%     
==========================================
  Files         214      214              
  Lines        8171     8179       +8     
  Branches     2200     2201       +1     
==========================================
+ Hits         7520     7527       +7     
- Misses        651      652       +1     
Flag Coverage Δ
UnitTests 92.02% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex
Copy link
Contributor

LGTM, is there any chance to create an intergration test as well

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans to support eth_maxPriorityFeePerGas method?
5 participants