This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Adjusted fromWei #7366
Closed
Adjusted fromWei #7366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TemirlanBasitov
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba,
krzysu and
danforbes
as code owners
avkos
suggested changes
Oct 31, 2024
| @@ -546,15 +554,9 @@ export const fromWei = (number: Numbers, unit: EtherUnits | number): string => { | |||
| const fraction = zeroPaddedValue.slice(-numberOfZerosInDenomination).replace(/\.?0+$/, ''); | |||
|
|
|||
| if (integer === '') { | |||
| return `0.${fraction}`; | |||
| return fraction ? `0.${fraction}` : "0"; | |||
There was a problem hiding this comment.
It will be great to add a unit test to cover this line. thanks
danforbes
reviewed
Oct 31, 2024
| @@ -2752,26 +2752,26 @@ If there are any bugs, improvements, optimizations or any new feature proposal f | |||
|
|
|||
There was a problem hiding this comment.
Are the changes to this file intentional?
|
The issue has been resolved with this PR, making this one no longer relevant. Thank you, @TemirlanBasitov, for your effort and contribution—it’s greatly appreciated! 🙌 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.