Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix typos RELEASE.md #7391

Closed
wants to merge 1 commit into from
Closed

fix typos RELEASE.md #7391

wants to merge 1 commit into from

Conversation

sky-coderay
Copy link

@sky-coderay sky-coderay commented Nov 15, 2024

Description

This pull request makes minor corrections to the documentation and text:

  • Replaced "do get introduced" with "get introduced" to remove unnecessary emphasis.
  • Updated "life cycle scripts" to "lifecycle scripts" for correct spelling.

These changes improve clarity and maintain consistency with standard English usage.

Type of change

image image
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@krzysu
Copy link
Contributor

krzysu commented Nov 16, 2024

Hey, thanks for your contribution, but we’re not accepting typo-fixing PRs. If you’d like to contribute, we encourage you to tackle a programming task instead. While there is a list of good first issues, all of them have already been assigned. Feel free to check back in a few weeks to see if new issues are available!

@krzysu krzysu closed this Nov 16, 2024
danforbes added a commit that referenced this pull request Nov 19, 2024
danforbes added a commit that referenced this pull request Nov 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants