Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

making sure that the route info object has the right shape before continuing #326

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Conversation

webark
Copy link
Owner

@webark webark commented Jun 24, 2019

This was happening when a transition is aborted when first loading the application and there isn't a from route yet, like ember-simple-auth is doing this if you are trying to access an authenticated route.

@webark webark merged commit 6a90a5b into webark:master Jun 24, 2019
@@ -3,7 +3,7 @@ language: node_js
node_js:
# we recommend testing addons with the same minimum supported node version as Ember CLI
# so that your addon works for all apps
- "8"
- "10"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is Node 8 no longer supported? is this a breaking change?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest fibers isn't supported by node 8 (it needs at least node 10). There is a dev dep that depends on the latest version of fibers (which I have considered rolling back just for this since it's my package).

This doesn't impact users of this as a dependency.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's true, but if we're no longer testing on Node 8 we might have other incompatible deps creep in 😉

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is true, which is why I was considering reverting away from the latest fibers version for the dependency. However, with the current version being in a kind of "maintenance mode" and node 8's end of life being only in 5 months, I thought that the risk was manageable.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only one of those was true, I'd be much more hesitant. With both of them, I feel comfortable with it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants