Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade MSFA to incorporate Dexed improvements and fixes #8

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

micahscopes
Copy link
Contributor

@micahscopes micahscopes commented Aug 4, 2021

changes

  • Integrates MSFA code from Dexed
    • slight, inconsequential adaptations were necessary to get this working
    • temporarily disabled new MSFA microtuning features
  • upgraded the build process to work with recent versions of emscripten
  • streamlined build/distribution process in Makefile
    • updated relevant build docs
  • clarified licensing for project and dependencies (fixes License? #7)
    • This library is MIT licensed, as clarified in License? #7
    • Dexed readme explicitly states that their MSFA changes maintain the original Apache 2.0 license, so I included original Google license doc in the MSFA source directory
    • New tuning-library dependency is permissively licensed (I think using MIT license)

context

I've been using webdx7 in a project and noticed that some of my presets weren't rendering correctly (compared to Dexed).

On investigation, I figured out that the Dexed contributors have made a number of improvements to the MSFA code, including tuning and additional implementation of DX7 features. My specific issues seemed to have to do with a previously unfinished LFO implementation.

While Dexed is GPL3, the project maintains the Apache license for its msfa changes, so there aren't
any license changes needed
@jariseon jariseon merged commit 8dba448 into webaudiomodules:master Aug 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License?
2 participants