-
Notifications
You must be signed in to change notification settings - Fork 364
feat(plugin-meetings): refactor StatsAnalyzer #4224
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: next
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Keeping this as draft until https://sqbu-github.cisco.com/WebExSquared/webrtc-media-core/pull/317 is merged. |
COMPLETES WEBEX-406371
This pull request addresses
Refactoring
StatsAnalyzer
fromwebrtc-media-core
.by making the following changes
Making the appropriate changes to use the new
StatsAnalyzer
code inwebrtc-media-core
.Change Type
The following scenarios were tested
All tests were done on the
webrtc-media-core
level using the SDK sample app. Tests were done on all browsers on both Windows and Mac, both individually and in a bug bash setting with the WCME team. See https://confluence-eng-gpk2.cisco.com/conf/display/webexmedia/StatsAnalyzer+Refactor+Test+Matrix for full test results.I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.