Skip to content

Update crud-controller.stub for Backpack v4 #40

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tabacitu
Copy link
Contributor

Description

Changes the crud-controller.stub to generate Backpack v4 controllers.

Motivation and context

The package did not provide a way to generate Backpack v4 controllers.

How has this been tested?

No, it has not! PLEASE DON'T MERGE THIS YET. Before we merge this we need:

Another IMPORTANT problem with this PR is that there's no backpack/crud requirement to webfactor/laravel-generators. This means that it assumes the user is running a certain Backpack version that is compatible with the stub. The current PR assumes they're running Backpack v4, since that's the current version, that everybody is installing (Solution 1).

(Solution 2) A different way to approach this would be to have two controller stubs: crud3-controller.stub and crud4-controller.stub, and before generating the crud controller, to see which Backpack version is installed and use the correct Stub. This is a little more complicated, but not too complicated. It would probably require adding a dependency (ocramius/package-versions) to check the currently installed version.

I don't know if it's really necessary though - why support Backpack 3.x when 4.x is here. What's you position on this? Solution 1 or Solution 2?

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant