Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Benefit from static analysis #52

Open
szepeviktor opened this issue Nov 8, 2019 · 1 comment · May be fixed by #83
Open

Benefit from static analysis #52

szepeviktor opened this issue Nov 8, 2019 · 1 comment · May be fixed by #83
Labels
help wanted Extra attention is needed

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Nov 8, 2019

Hello!
You may reach very robust code by using @phpstan

phpstan.neon.dist

#$ composer require --dev phpstan/phpstan-shim
#$ vendor/bin/phpstan analyze

includes:
    - phar://phpstan.phar/conf/bleedingEdge.neon
parameters:
    level: 2
#    level: 4
#    level: max
    inferPrivatePropertyTypeFromConstructor: true
    paths:
        - %currentWorkingDirectory%/src/
#        - %currentWorkingDirectory%/test/
    ignoreErrors:
        #
        # These are way too easy to fix!
        - '#^Variable \$\S+ might not be defined\.$#'
        - '#^Access to an undefined property WebimpressCodingStandard\\\S+\.$#'
@michalbundyra
Copy link
Member

@szepeviktor I'd be happy to see some PR with fixed issues and proper configuration :) Thanks!

@michalbundyra michalbundyra added the help wanted Extra attention is needed label Jan 25, 2020
szepeviktor added a commit to szepeviktor/coding-standard-1 that referenced this issue Jan 25, 2020
@szepeviktor szepeviktor linked a pull request Jan 25, 2020 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants