-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add "Die On: warning" to spec metadata #468
Comments
@inexorabletash, great idea! @dontcallmedom, wouldn't a simple (I note the spec-prod example workflow https://github.com/w3c/spec-prod/blob/main/docs/examples.md does not define any exit behaviour on build errors. Should this default be liberal or not? Just wondering.) |
|
@inexorabletash, maybe we should also fail the CI build similarly as in #469? The in-spec metadata directive will catch local build experiments. |
Yes, failing CI is also a good idea. |
Although not yet documented, Bikeshed now supports setting the default
--die-on
in the spec metadata. We should make warnings fatal so contributors don't need to remember to specify--die-on=warning
manually.This should just require adding this to the
<pre class='metadata'>
block at the top of the spec:Also, I'm explicitly suggesting "warning" rather than "link-error" because the spec is currently clean for warnings and most Bikeshed warnings really do flag that something is wrong, so we don't want to regress.
The text was updated successfully, but these errors were encountered: