增加onConsumeFailure方法，适配最新版本 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkor
reviewed
Feb 28, 2024
| @@ -62,9 +63,12 @@ public function onWorkerStart() | |||
| $queue = $consumer->queue; | |||
| $connection = Client::connection($connection_name); | |||
| $connection->subscribe($queue, [$consumer, 'consume']); | |||
| //Add onConsumeFailure method to Consumer class in Consumer.php | |||
There was a problem hiding this comment.
这样写看起来有问题，如果有多个消费者，只有最后一个消费者的onConsumeFailure设置成功，之前的会被覆盖。
|
代码已经更改完毕,测试也正常,@walkor老大看看还有没有问题 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加onConsumeFailure方法，适配最新版本的redis-queue，可选.