Reorganize workflows #100
Merged
Reorganize workflows #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwaway96
force-pushed
the
reorganize-workflows-20240317
branch
from
6b60eca to
3462791
Compare
throwaway96
force-pushed
the
reorganize-workflows-20240317
branch
2 times, most recently
from
ffb8551 to
d6eb2dd
Compare
throwaway96
force-pushed
the
reorganize-workflows-20240317
branch
from
17b1a3b to
0e38925
Compare
Includes some fixes in obtain_manifest().
The "app-lint" check has been replaced with "pr-check", which also includes checking site generation when appropriate.
throwaway96
force-pushed
the
reorganize-workflows-20240317
branch
from
0e38925 to
8cc58ed
Compare
mariotaku
approved these changes
Mar 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly combines the common parts of the site-related workflows into a reusable workflow. It also updates some of the actions used.
While testing the package lint part, I came across some preexisting issues.
A malformed package manifest (or a number of other errors) could cause the workflow to fail prematurely and produce incomplete output when reporting results. This PR should resolve the biggest problems.
Here is an example of an old report. It is missing the second section because the step failed before it reached that part. If there were multiple packages modified, I believe it would have errored out on the first one that failed during downloading.
Here is an example of a new report, which is far from perfect but at least lets you know something went wrong. It should continue to check subsequent modified packages, although I haven't specifically tested that yet.
Otherwise, everything I've been able to test so far has worked.