Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] support {String} patterns #150

Closed
cletusw opened this issue Oct 5, 2017 · 2 comments
Closed

[Feature] support {String} patterns #150

cletusw opened this issue Oct 5, 2017 · 2 comments

Comments

@cletusw
Copy link
Contributor

cletusw commented Oct 5, 2017

Feature request: Could the patterns array support plain old strings, where

patterns: [
  'myFile.txt'
]

is equivalent to

patterns: [{
  from: 'myFile.txt'
}]

?

This would reduce boilerplate when many of the copy patterns are simple.

If this is okay, I can implement the PR.

@michael-ciniawsky
Copy link
Member

Always feel free to send a PR as it is even easier to triage feature implementations that way :) There is no guarantee if it lands as it always requires sign-off from 2+ maintainers at minimum. The proposal seems reasonable enough through (from a first glance)

@michael-ciniawsky michael-ciniawsky changed the title Support string patterns (instead of objects) [Feature] support {String} patterns Oct 5, 2017
@cletusw
Copy link
Contributor Author

cletusw commented Oct 5, 2017

@michael-ciniawsky Will do! Some projects have explicit rules against submitting PRs that haven't been raised as an issue first, so I just wanted to be sure. Thanks!

cletusw added a commit to cletusw/copy-webpack-plugin that referenced this issue Oct 10, 2017
cletusw added a commit to cletusw/copy-webpack-plugin that referenced this issue Oct 11, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants