feat: use template literal when it possible to prevent `Maximum call … #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stack size exceeded`
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
+ Coverage 96.76% 96.87% +0.10%
==========================================
Files 10 10
Lines 1145 1185 +40
Branches 421 456 +35
==========================================
+ Hits 1108 1148 +40
Misses 28 28
Partials 9 9
☔ View full report in Codecov by Sentry. |
|
Could possibly infer this from browserslist? |
|
@sgarfinkel We already do it on webpack side level https://webpack.js.org/configuration/target/, so if you have |
|
alexander-akait
deleted the
feat-generate-template-literal-when-it-possible
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stack size exceeded`
This PR contains a:
Motivation / Use-Case
fixes #771
Breaking Changes
No
Additional Info
No